Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid escaping of quote in string argument #18

Merged
merged 2 commits into from
May 8, 2021

Conversation

pkosiec
Copy link
Contributor

@pkosiec pkosiec commented Apr 11, 2021

The issue in graphql-go/graphql dependency has been just merged: graphql-go/graphql#587

This pull request:

  • changes dependency from carted/graphql (outdated fork of graphql-go/graphql) to graphql-go/graphql (latest commit from master)
  • adds test case to make sure the input string is escaped correctly

See the original issue on nautilus/gateway: nautilus/gateway#121

@pkosiec
Copy link
Contributor Author

pkosiec commented Apr 11, 2021

The build is failing, but looks like it's CI job issue:

$HOME/gopath/bin/goveralls -coverprofile=coverage.out -service=travis-ci -repotoken $COVERALLS_TOKEN

flag needs an argument: -repotoken

Probably that's because the PR is created from fork and the secret is not available during job run.

@pkosiec
Copy link
Contributor Author

pkosiec commented Apr 27, 2021

Hi @AlecAivazis, could you please take a look? It's a very small PR with dependency bump and one test case as discussed in autilus/gateway#121. Thanks a lot!

@pkosiec
Copy link
Contributor Author

pkosiec commented May 8, 2021

Hello @AlecAivazis, please take a look once you have a moment 🙂 Thanks!

@AlecAivazis
Copy link
Member

Oh damn!! So sorry for not seeing this

@AlecAivazis AlecAivazis merged commit 0287975 into nautilus:master May 8, 2021
@AlecAivazis
Copy link
Member

This has now been released under v0.0.16. I'll keep an eye out for the following bump in the gateway - thanks for being so patient!

@pkosiec
Copy link
Contributor Author

pkosiec commented May 8, 2021

🎉 Thank you, @AlecAivazis! Will do the bump in a moment 👍

@pkosiec
Copy link
Contributor Author

pkosiec commented May 8, 2021

@AlecAivazis Here it is: nautilus/gateway#139

@pkosiec pkosiec deleted the fix-json-arg branch May 8, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants