Add provider class for Nautobot Secrets Functionality #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
glennmatthews
approved these changes
Jan 7, 2022
itdependsnetworks
approved these changes
Jan 8, 2022
qduk
approved these changes
Jan 10, 2022
dgarros
reviewed
Jan 10, 2022
|
After discussions the config_context is the path forward on defining plugin(device) specific settings. |
|
@itdependsnetworks @dgarros anything else now that we have our path forward? This PR should be good to merge. |
|
Perhaps one question is whether to have two different options in the config on whether to use config_context for secrets then another one for extras (from other PR). I think one trigger should work. |
|
I think it should be 2 config keys. |
|
Was thinking {"use_config_context": {"secrets": True, "connection_options": True}} |
|
I like it |
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
glennmatthews
approved these changes
Jan 24, 2022
…bot-plugin-nornir into jkala-secrets-integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #44
This allows for secrets group feature to be used to provide username, password, secret.