Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed line to copy non-existant bin folder #165

Merged
merged 1 commit into from
May 25, 2023
Merged

removed line to copy non-existant bin folder #165

merged 1 commit into from
May 25, 2023

Conversation

SammySteiner
Copy link
Contributor

@SammySteiner SammySteiner commented May 25, 2023 •
edited
Loading

Ticket

Issue #164

Changes

Removed command to copy nonexistent bin folder from installation instructions in the readme.

Context for reviewers

Follow installation instructions by copying and pasting commands into a new folder and ensure the error: cp: template-application-flask/bin: No such file or directory no longer appears.

Testing

With error:
Screenshot 2023-05-25 at 10 29 58 AM

Without error:
Screenshot 2023-05-25 at 10 30 46 AM

@SammySteiner SammySteiner requested a review from lorenyu May 25, 2023 14:32
lorenyu
lorenyu approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@lorenyu lorenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SammySteiner SammySteiner merged commit b6ca539 into main May 25, 2023
@SammySteiner SammySteiner deleted the sammysteiner/installation-instruction-remove-bin branch May 25, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenyu lorenyu lorenyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SammySteiner @lorenyu