Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PanoViewer.isWebglAvailable Should return value if Panoviewer is available. #243

Closed
jongmoon opened this issue Nov 23, 2018 · 0 comments
Closed

PanoViewer.isWebglAvailable Should return value if Panoviewer is available. #243

jongmoon opened this issue Nov 23, 2018 · 0 comments
Assignees
@jongmoon
Labels
🌐 PanoViewer (v3) Issues related to PanoViewer (View360 v3)
Milestone
3.2.0

Comments

@jongmoon
Copy link

Description

PanoViewer.isWebGLAvailable() function returns the value it means this browser supports webgl or not. But this function is only needed only if PanoViewer is available. Value whether WebGL supports or not is not useless.

So It's prefer to return value if PanoViewer is available.
@jongmoon jongmoon self-assigned this Nov 23, 2018
@jongmoon jongmoon added this to the 3.2.0 milestone Nov 23, 2018
@jongmoon jongmoon added the 🌐 PanoViewer (v3) Issues related to PanoViewer (View360 v3) label Nov 23, 2018
jongmoon pushed a commit to jongmoon/egjs-view360 that referenced this issue Nov 23, 2018
chore(PanoViewer): isWebGLAvailable spec change
f7ab30c 
isWebGLAvailable should return true if PanoViewer is avilable.

Ref naver#243
@jongmoon jongmoon mentioned this issue Nov 23, 2018
Merged
jongmoon pushed a commit to jongmoon/egjs-view360 that referenced this issue Nov 27, 2018
test(PanoViewer): enhance panorama test
eaf636e 
 - local file as a input
 - navigator

Ref naver#243
jongmoon pushed a commit to jongmoon/egjs-view360 that referenced this issue Nov 27, 2018
skip: method 'isSupported' is added
88b1c17 
Ref naver#243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jongmoon jongmoon

Labels
🌐 PanoViewer (v3) Issues related to PanoViewer (View360 v3)
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
1 participant
@jongmoon