Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check chromium version for device motion issue #280

Closed
jongmoon opened this issue Feb 12, 2019 · 0 comments
Closed

Check chromium version for device motion issue #280

jongmoon opened this issue Feb 12, 2019 · 0 comments
Assignees
Labels
✨ Feature Introduce new feature

Comments

@jongmoon
Copy link

Description

Currently device motion is branched by browser version which is acquired by egjs-agent. But we can not acquire version of browser engine. For example of Samsung internet Browser, we can get browser name (Samsung Internet) and its version. But We can not get chromium version. And Version of chromium affect on device motion (Related #172, #173)

So we should check it by checking userAgent string directly or change egjs-agent to return browser engine. But we should check it by first one until policy of egjs-agent is decided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature Introduce new feature
Projects
None yet
Development

No branches or pull requests

1 participant