Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle promise polyfill for IE11 #274

Merged
merged 2 commits into from
Jan 2, 2019
Merged

Bundle promise polyfill for IE11 #274

merged 2 commits into from
Jan 2, 2019

Conversation

jongmoon
Copy link

@jongmoon jongmoon commented Jan 2, 2019

Issue

Ref #272

Details

  • It's omitted at 3.2.0 release by changing bundler from webpack to rollup.
  • Because babel-plugin-es6-promise use require for importing module. but rollup does not change it.
  • So change babel-plugin-es6-promise to use import for importing moulde.

Jongmoon Yoon added 2 commits January 2, 2019 16:56
chore(demo): add home link to all demo
a6eeba3 
Ref naver#271
chore(env): bundle promise polyfill
85c0a8b 
  - Change the babel plugin to es6-promise-esm
  - it uses import instead of require

Ref naver#272
@jongmoon jongmoon requested a review from daybrush January 2, 2019 09:05
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.729% when pulling 85c0a8b on jongmoon:ie11#272 into ca6e569 on naver:master.

daybrush
daybrush approved these changes Jan 2, 2019
View reviewed changes
Copy link
Member

@daybrush daybrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jongmoon jongmoon merged commit 3118225 into naver:master Jan 2, 2019
@jongmoon jongmoon added the 🐛 Bug Something isn't working label Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daybrush daybrush daybrush approved these changes

Assignees
No one assigned
Labels
🐛 Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jongmoon @coveralls @daybrush