Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(PanoViewer): apply changed interface #73

Merged
merged 65 commits into from
Dec 5, 2017
Merged

test(PanoViewer): apply changed interface #73

merged 65 commits into from
Dec 5, 2017

Conversation

jongmoon
Copy link

@jongmoon jongmoon commented Dec 4, 2017

Issue

#72

Details

apply changed interface followed by #44

Jongmoon Yoon and others added 30 commits November 10, 2017 19:05
feat(VideoLoader): add video loader module
0431ca2 
Ref naver#44
fix(ImageLoader): apply loadStatus instead of image.complete
5797ebe 
image.complete is not valid to check image is loaded.

Ref: https://stackoverflow.com/questions/23657424/why-image-complete-property-always-return-true-even-if-there-is-no-src-tag

Ref naver#44
feat(all): support video content
ab1fc7e 
Ref naver#44
skip: remove only flag
2a93d8c
test(ImageLoader): satisfy 100% coverage
e3c2d90
skip: fix test typo error
d71b053
chore(all): apply circular fixed axes version.
38d5e0b 
Ref naver#49
docs(README): update axes version.
41abc1a 
Ref naver#49
test(YawPitchControl): update test case by fixing circular bugs.
d31fac3 
Ref naver#49
Merge pull request naver#50 from jongmoon/axes#49
6411324 
Apply axes 2.3.0
Merge branch 'master' of https://github.com/jongmoon/egjs-view360 int…
e3009b1 
…o video#44
skip: apply review, jsdoc for error message.
a14813e
skip: review applied. use read-only property to check image loaded.
fb5af1d
@happyhj
chore(release): ready to qa
c1210c6 
added dist files
@happyhj
fix(SpinViewer): tune sensitivity
99ec161 
Ref naver#54
@happyhj
chore(package): add egjs-visible for testing visible
82a3517 
Ref naver#55
@happyhj
test(PanoViewer): add visible library to manual test folder
9b30947 
and include visible module in the visible.html

Ref naver#55
@happyhj
fix(YawPitchControl): fix showPole keyword to showPolePoint
ed9d3e5
@happyhj
fix(PanoViewer): remove fov adjust block nor needed
83b6675 
removed this._fov adjust block not using anymore
fixed unused type checking in PanoImageRenderer
add cubemap test preset to panoviewer manual test
apply showPolePoint name change to unit test
@happyhj
test(PanoViewer): remove es6 syntex for ie11 support
bceaceb
@happyhj
test(PanoViewer): add Object.assign Polypill for IE11
3917e72
@happyhj
test(PanoViewer): change imageType to vertical_cubestrip
8fd2e0c
@happyhj
skip: dist files update
0daeafb
@happyhj
test(PanoViewer): make option panel closed when loaded
99f0255
@happyhj
test(PanoViewer): show when webgl is not supported
4c88c7d
@happyhj
test(all): show alert when no webgl support
20d2336
@happyhj
skip: update map files.
6dfd87e
@happyhj
fix(YawPitchControl): fix _updateControlScale to work with change event
058b0df 
add unit test

ref naver#64
@happyhj
skip: update dist files
1ffe280
@happyhj
fix(FusionPoseSensor): skip first orientation event
57dfc60 
add complementary filter with checking initialized flag attached
add unit test

ref naver#66
happyhj and others added 26 commits November 28, 2017 17:50
@happyhj
chore(release): merge 2.0.1-rc
20d336a
@happyhj
skip: remove dist
1c085a6
fix(ImageLoader): prevent event firing after destroy
bef8a12
skip: apply review - change set/get interface
7b4f6f3
fix(VideoLoader): prevent event firring after destroy
ba83d18
feat(PanoViewer): replace imageType with projectionType
80bd42c 
Ref naver#44
test(PanoViewer): apply changed interface on demo
d01a7c7 
Ref naver#44
test(PanoViewer): PanoVideo -resize handling
b0ac8f1 
Ref naver#44
@happyhj
test(PanoImageRenderer): added equirectangular render test (naver#47)
286f355 
make travis-ci to use gl disabled headless chrome
add prepush hook for webgl testing on local browser

ref naver#45
skip: review apply
2a9a418 
  - refactoring ImageLoader
skip: review apply
61e3e81 
use readyState to check if loaded

Ref naver#44
skip: review applied
1b6d7cf 
add getter for loadStatus

Ref naver#44
skip: review applied
6710f4b 
change log

Ref naver#44
skip: review applied
de59b6d 
Ref naver#44
skip: review apply
b7930d1 
replace width/height with naturalWidth/naturalHeight to use origingal size

Ref naver#44
skip: apply review
c4c0b01 
change aync test can be stopped

Ref naver#44
skip: merge master
912b0da
fix(ImageLoader): replace onload with addEventListener
8c270f7 
For not to replace original onload event on image.
skip: merge master with video branch and migrate code.
084fe66
Merge branch 'video#44' into video#44
394e5e4
Merge branch 'video#44' into video#44
21ee120
skip: lint error while resolving conflict on github
9a05003
test(PanoViewer): apply changed interaface
649d62d 
Ref naver#72
test(PanoViewer): apply changed interface after supporting video
fe8c4c1 
Ref naver#72
test(PanoViewer): apply changed interface by supporting video
e89c47a 
Ref naver#72
skip: resolve conflict on PanoViewer
43da74c
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 45.845% when pulling 43da74c on jongmoon:video#44 into 97c33a1 on naver:video#44.

happyhj
happyhj approved these changes Dec 4, 2017
View reviewed changes
Copy link
Contributor

@happyhj happyhj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jongmoon jongmoon merged commit cbf0cce into naver:video#44 Dec 5, 2017
@jongmoon jongmoon deleted the video#44 branch December 5, 2017 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happyhj happyhj happyhj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jongmoon @coveralls @happyhj