Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging video branch with master #97

Merged
merged 37 commits into from
Dec 26, 2017
Merged

Conversation

jongmoon
Copy link

Issue

#44

Jongmoon Yoon and others added 30 commits November 13, 2017 18:02
and include visible module in the visible.html

Ref naver#55
removed this._fov adjust block not using anymore
fixed unused type checking in PanoImageRenderer
add cubemap test preset to panoviewer manual test
apply showPolePoint name change to unit test
add complementary filter with checking initialized flag attached
add unit test

ref naver#66
@coveralls
Copy link

Coverage Status

Coverage increased (+26.9%) to 72.689% when pulling 0ca0b25 on jongmoon:video#44 into 1a1cbfb on naver:video#44.

Copy link
Contributor

@happyhj happyhj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jongmoon jongmoon closed this Dec 26, 2017
@jongmoon jongmoon reopened this Dec 26, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+26.9%) to 72.689% when pulling 0ca0b25 on jongmoon:video#44 into 1a1cbfb on naver:video#44.

@jongmoon jongmoon merged commit b4d3173 into naver:video#44 Dec 26, 2017
@jongmoon jongmoon deleted the video#44 branch January 16, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants