Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When markup is already prepared, filcking does not find elements #216

Closed
sculove opened this issue May 18, 2016 · 1 comment
Closed

When markup is already prepared, filcking does not find elements #216

sculove opened this issue May 18, 2016 · 1 comment
Assignees
@netil
Labels
enhancement flicking
Milestone
1.3.0

Comments

@sculove
Copy link
Contributor

sculove commented May 18, 2016

Description

When elements have eg-flick-contiainer class or eg-flick-pannel class, filcking ignore this elements.
I wish eg.Flcking uses this elements if elements would have eg-flick-XXX class.
@sculove sculove changed the title When makeup is already prepared, filcking does not find elements When markeup is already prepared, filcking does not find elements May 18, 2016
@sculove sculove changed the title When markeup is already prepared, filcking does not find elements When markup is already prepared, filcking does not find elements May 18, 2016
@netil netil self-assigned this May 31, 2016
@netil netil modified the milestone: 1.3.0 Jun 28, 2016
@netil
Copy link
Member

netil commented Aug 3, 2016

There're several consideration on implementing that.
container element is quite easy, because it exist only one, but in term of panel elements just checking the existence isn't enough.

If panels aren't enough to run in some circumstances(ex. previewPadding option is given, but just only on panel element is set), what will be the action for that?

  • Just checking existence of container and panel elements is okay?
  • Should take consideration on panel elements count also?

netil added a commit to netil/egjs that referenced this issue Aug 8, 2016
@netil
feat(Flicking): Handle when container element is given
9597539 
When container-ish element exist, wrapping panel elements, then use given element
instead of wrapping with new one.

Ref naver#216
@netil netil mentioned this issue Aug 8, 2016
Closed
@netil netil closed this as completed in 2773a7a Aug 12, 2016
@netil netil mentioned this issue Aug 26, 2016
Merged
@sculove sculove mentioned this issue Jan 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netil netil

Labels
enhancement flicking
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
2 participants
@sculove @netil