Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.2.0 script error #274

Closed
kimshinelove opened this issue Jun 30, 2016 · 2 comments
Closed

1.2.0 script error #274

kimshinelove opened this issue Jun 30, 2016 · 2 comments
Assignees
@jongmoon
Labels
animate bug
Milestone
1.3.0

Comments

@kimshinelove
Copy link

kimshinelove commented Jun 30, 2016 •
edited by ajaxpf
Loading

Description

The logic which works correctly on 1.1.0, but gives error on 1.2.0.
I looked up and reproduced as below.

Steps to check or reproduce

reproduce

when:

$(el).stop();

then
2016-06-30 7 42 58
@jongmoon jongmoon self-assigned this Jun 30, 2016
@ajaxpf ajaxpf changed the title 1.2.0 스크립트 오류 1.2.0 script error Jul 1, 2016
@ajaxpf
Copy link
Collaborator

ajaxpf commented Jul 1, 2016

@kimshinelove, I translated your issue. We're trying to make all communications on english :)

jongmoon pushed a commit to jongmoon/egjs that referenced this issue Jul 1, 2016
fix(pauseResume): Fix a script error on stop()
f9f5ebc 
When you call it on elements which is not animated,
script error occurs because __aniProp is not exist.

Ref naver#274
@jongmoon jongmoon mentioned this issue Jul 1, 2016
Merged
@jongmoon
Copy link
Contributor

jongmoon commented Jul 1, 2016

@kimshinelove Thank you very much for reporting error!

It is a BUG which occurs on no-animate element.
I've just pushed request(#276)

I'll send you fixed version as soon as possible.

@jongmoon jongmoon added this to the 1.3.0 milestone Jul 7, 2016
@mixed mixed modified the milestone: 1.3.0 Jul 7, 2016
@jongmoon jongmoon closed this as completed Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jongmoon jongmoon

Labels
animate bug
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
5 participants
@mixed @sculove @kimshinelove @jongmoon @ajaxpf