Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve .resize() when adaptiveHeight option is used #478

Closed
netil opened this issue Mar 15, 2017 · 0 comments
Closed

Improve .resize() when adaptiveHeight option is used #478

netil opened this issue Mar 15, 2017 · 0 comments
Assignees
Milestone

Comments

@netil
Copy link
Member

netil commented Mar 15, 2017

Description

When adpativeHeight option is set, internally panel's height value is set to on element's attribute.
This behavior is to perform more efficiently not re-evaluate height on every flick action.

But, in the circumstances which needed to call .resize() (which means situation like orientation of device has been changed), the panel's height needed to re-evaluate depending on the contents its have.

@netil netil added this to the 1.5.0 milestone Mar 15, 2017
@netil netil self-assigned this Mar 15, 2017
netil added a commit to netil/egjs that referenced this issue Mar 21, 2017
In case of rotate(or in case of panel's height changes), need to re-evaluate panel's height value.
This fixes removing 'data-height' attribute and re-evaluate calling ._setAdaptiveHeight().

Ref naver#478
@netil netil closed this as completed in 7a49618 Mar 21, 2017
sculove pushed a commit to naver/egjs-flicking that referenced this issue Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant