Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(srollend,rotate) : Event style have changed jindo to jquery. #207

Merged
merged 6 commits into from
May 26, 2016
Merged

fix(srollend,rotate) : Event style have changed jindo to jquery. #207

merged 6 commits into from
May 26, 2016

Conversation

mixed
Copy link
Member

@mixed mixed commented May 11, 2016 •
edited
Loading

Issue

#174

Details

rotate

  • Add jQuery style
  • Fixed documention
  • Add testcase

scrollend

  • Fixed documention
  • Add testcase

Preferred reviewers

@jongmoon @happyhj

mixed added 2 commits May 11, 2016 17:44
@mixed
test(rotate): When browser rotate It have to fire rotate event with i…
944d8da 
…nfo.

- Fixed documention
- Add Testcase

Ref naver#174
@mixed
fix(scrollend): Add info object when fire scrollend with.
54e6b04 
Add jQuery style.
I can`t remove jindo style since version compatibility.

Ref naver#174
sculove
sculove reviewed May 11, 2016
View reviewed changes
src/customEvent/rotate.js
@@ -17,13 +17,12 @@ eg.module("rotate", ["jQuery", eg, window, document], function($, ns, global, do
*
* @ko jQuery custom rotate 이벤트 지원
* @name jQuery#rotate
* @event
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you shouldn't remove @event tag.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sculove
Um.. It isn't event. I think that just information object like jQueryUI. Although it be ambiguous I think It is more @info than @event. Let's talk about this issues next week discuss.

@jongmoon
Copy link
Contributor

LGTM

@mixed mixed merged commit 54e0301 into naver:master May 26, 2016
@mixed mixed mentioned this pull request May 26, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mixed @jongmoon @sculove