fix(MovableCoord): fire release event #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 12, 2016 15:38
fire release event when moved different direction that was set. Ref naver#288
| } else if (e.isFinal && e.direction !== MC.DIRECTION_NONE && | ||
| !(e.direction & this._subOptions.direction)) { | ||
| // Although direction of movement is different from options.direction, MC should fire 'release' event. | ||
| this._panend(e); |
There was a problem hiding this comment.
@jongmoon you'd better make _triggerRelease method like this
_triggerRelease: function(e) {
this._setInterrupt(false);
this.trigger("release", {
//...
});and I find potential bug due to your PR.
we should also initalize this._status.moveDistance
thanks
There was a problem hiding this comment.
@sculove OK, I also think that _panend do much~
I'm happy to help you find the potential bug related with moveDistance.
| @@ -411,7 +413,7 @@ eg.module("movableCoord", ["jQuery", eg, window, "Hammer"], function($, ns, glob | |||
| } | |||
|
|
|||
| // Abort the animating post process when "tap" occurs | |||
| if (e.type === "tap") { | |||
| if (e.distance === 0 /*e.type === "tap"*/) { | |||
There was a problem hiding this comment.
you should remove tap recognizer in _createHammer method.
There was a problem hiding this comment.
@sculove I applied it yesterday.
added 2 commits
July 25, 2016 20:19
|
LGTM |
|
👍 |
This was referenced Aug 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#288
Details
Although direction of movement is different from options.direction, MC should fire 'release' event.
Preferred reviewers
@sculove, @netil, @mixed
@netil it's related with
eg.flicking