fix(infiniteGrid): fix image check module in IE9 #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -824,8 +824,10 @@ eg.module("infiniteGrid", ["jQuery", eg, window, document, "Outlayer"], function | |||
| $(e.target).off("load error"); | |||
| checkCount <= 0 && callback && self.core && callback.apply(self); | |||
| }; | |||
| var $el; | |||
There was a problem hiding this comment.
Is necessary to declare outside of function?
There was a problem hiding this comment.
It's not necessary. I want to declare a variable before running each method.
There was a problem hiding this comment.
I think is creating unused closure scope.
There was a problem hiding this comment.
@netil I think he(@sculove) worries about performance. But It does not make matter anymore.
http://jindo.dev.naver.com/jsMatch/index.html?d=256&openResult=1
So I'm OK to remove var $el. but current code looks fine to me.
Anyway I don't think there will be closure issue. I think $el will be remove from memory after this function is ended.
|
LGTM |
This was referenced Aug 22, 2016
netil
pushed a commit
that referenced
this pull request
Dec 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#309
Details
IE9 couldn't unaware
loadevent of imagesPreferred reviewers
@kishu