Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a logarithmic volume slider #668

Closed
wanieru opened this issue Nov 28, 2020 · 5 comments
Closed

Use a logarithmic volume slider #668

wanieru opened this issue Nov 28, 2020 · 5 comments

Comments

@wanieru
Copy link

wanieru commented Nov 28, 2020

Correct me if I'm wrong, but the volume slider is currently implemented linearly?
Volume controls are much better when implemented as a logarithmic volume slider. It matches the way human hearing works. It makes turning the volume down from 100% to 50% actually impactful, instead of barely making a difference.
For me, this is currently my preferred volume: https://i.imgur.com/e4B0lu2.png.
See this thread for some detail: https://ux.stackexchange.com/a/116300

@certuna
Copy link
Contributor

certuna commented Nov 28, 2020

This is probably better posted as an issue with the upstream react player: https://github.com/lijinke666/react-music-player

@andrewzah
Copy link

Made an issue: lijinke666/react-music-player#227

@andrewzah
Copy link

The issue was just closed- we'll need to implement this feature manually.

@danshilm
Copy link
Contributor

lijinke666/react-music-player#266 was merged.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants