Use non-linear volume slider #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Options:
|
Features
Bug Fixes
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
|
✔️ Deploy preview for react-jinke-music-player ready! 🔨 Explore the source changes: 5e8eccd 🔍 Inspect the deploy logs: https://app.netlify.com/sites/react-jinke-music-player/deploys/5ffca72df8bae300071c0eb5 😎 Browse the preview: https://deploy-preview-266--react-jinke-music-player.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
+ Coverage 76.44% 76.57% +0.13%
==========================================
Files 21 21
Lines 866 871 +5
Branches 223 223
==========================================
+ Hits 662 667 +5
Misses 153 153
Partials 51 51
|
|
Thanks. A lot of people want me to add features that they want, but nobody wants to do it themselves, thank you for your work |
|
🎉 This PR is included in version 4.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a non-linear volume slider (#227)
Now, when you drag the volume slider to 50% it feels closer to a 50% reduction in perceived volume.
Other changes
props.onAudioVolumeChangeis called, the precision of the parameter is increased to 4 decimal values. This is because when you adjust the volume at values closer to 0, there is a bigger difference in perceived volume.