Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and use node18 #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

humphd
Copy link

@humphd humphd commented Apr 3, 2023

Thanks a lot for adding SHA256 to the webhook action. We've needed it in our project and your code has been working great!

I wanted to send a PR to update the deps and move the runtime to node 18, since it's starting to give various warnings for things that are out of date.

I'm not 100% sure how to test this outside of a workflow run. The major changes here are:

  1. move from node12 to node18 (see [all OSs] Default Nodejs version will be set to 18 on February, 13 actions/runner-images#7002)
  2. updated axios and moved data into the config options (see https://www.npmjs.com/package/axios#axios-api). If you're comfortable, I'd switch to use fetch() and drop the dep, but it's still experimental.
  3. updated the other deps, which doesn't affect how you're using them

Let me know if you notice anything you want done differently, or will be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant