Feature/nav 140 utility endpoints health and service info #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the schedule and routeing controller
…n various methods across the package
… and not found resources
…NAV-140-Utility-endpoints-Health-and-ServiceInfo
- Add actuator dependency. - Configuration via application.properties
- Run swagger UI on further endpoints. - Serve application documentation as JSON. - Make git and build information available to Spring app.
- Add controller for home "/" endpoint. - New thymeleaf dependency. - Index template and logo.
- Improve design of home. - Move configs into separate app.config package.
- Ignore git specifics in docker build to not expose git specifics in production images.
…vided in routing controller - Instead of checking coordinates against negative values, are against null now. - In the swagger UI the default value is now not set. - Update description of swagger.
…er max value as default value in the API. - Swagger UI is more readable. - Adjust parameter validation.
- Catch exceptions from raptor algorithm and rethrow as ConnectionRoutingException. - Adjust signatures.
…in input parameters
- Implementation for gtfs raptor service, based on the gtfs schedule.
- Belongs semantically to the schedule.
- Handles stop lookups and validation. - Handles datetime validation and validity check.
- Refactor test: Move test cases into individual nested test classes. - Unify naming of test cases.
Note: Metrics should not be exposed when in production.
clukas1
reviewed
Aug 15, 2024
There was a problem hiding this comment.
From what I can tell changes look food.
Only remaining point I see is the implementation of our date ranges in the gtfs raptor service.:
- Getting start and end date only by streaming the calendars and ignoring exceptions will not always work.
- What about cases where there is no active service for a day within the range?
- Since this check will run many times (for each request) I wouldn't calculate the ranges every time but store them as attributes.
src/main/java/ch/naviqore/service/gtfs/raptor/GtfsRaptorValidity.java
Outdated
Show resolved
Hide resolved
…n if file is required, log warning otherwise
munterfi
deleted the
feature/NAV-140-Utility-endpoints-Health-and-ServiceInfo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
/.ConnectionRoutingRequestto theConnectionRoutingInterface. In the service,IllegalArgumentExceptions are caught from theRaptorRouterand converted toConnectionRoutingExceptions at the service level. These error messages are forwarded to the user, and the stack trace is logged. Other exceptions (e.g.,NullPointerExceptions) are not caught, and therefore the client receives a generic internal server error.Validitycheck at the service level, which is used to validate date and time input from the client.RoutingControllerandScheduleControllerTest.