Skip to content

Commit

Permalink
Append 'ws://' prefix if url starts with localhost (#132)
Browse files Browse the repository at this point in the history
* test: refactor NormalizeURL tests

* feat(NormalizeURL): add 'ws://' prefix if url starts with 'localhost'

* test(NormalizeURL): add 'ws://' prefix if url is localhost
  • Loading branch information
patrickReiis committed Jul 4, 2024
1 parent 6ed112c commit 8aaf5b8
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 27 deletions.
4 changes: 4 additions & 0 deletions normalize.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ func NormalizeURL(u string) string {
u = strings.TrimSpace(u)
u = strings.ToLower(u)

if strings.HasPrefix(u, "localhost") == true {
u = "ws://" + u
}

if !strings.HasPrefix(u, "http") && !strings.HasPrefix(u, "ws") {
u = "wss://" + u
}
Expand Down
58 changes: 31 additions & 27 deletions normalize_test.go
Original file line number Diff line number Diff line change
@@ -1,32 +1,36 @@
package nostr

import "fmt"
import (
"testing"
)

func ExampleNormalizeURL() {
fmt.Println(NormalizeURL(""))
fmt.Println(NormalizeURL("wss://x.com/y"))
fmt.Println(NormalizeURL("wss://x.com/y/"))
fmt.Println(NormalizeURL("http://x.com/y"))
fmt.Println(NormalizeURL(NormalizeURL("http://x.com/y")))
fmt.Println(NormalizeURL("wss://x.com"))
fmt.Println(NormalizeURL("wss://x.com/"))
fmt.Println(NormalizeURL(NormalizeURL(NormalizeURL("wss://x.com/"))))
fmt.Println(NormalizeURL("x.com"))
fmt.Println(NormalizeURL("x.com/"))
fmt.Println(NormalizeURL("x.com////"))
fmt.Println(NormalizeURL("x.com/?x=23"))
type urlTest struct {
url, expected string
}

var urlTests = []urlTest{
{"", ""},
{"wss://x.com/y", "wss://x.com/y"},
{"wss://x.com/y/", "wss://x.com/y"},
{"http://x.com/y", "ws://x.com/y"},
{NormalizeURL("http://x.com/y"), "ws://x.com/y"},
{NormalizeURL("wss://x.com"), "wss://x.com"},
{NormalizeURL("wss://x.com/"), "wss://x.com"},
{NormalizeURL(NormalizeURL(NormalizeURL("wss://x.com/"))), "wss://x.com"},
{"wss://x.com", "wss://x.com"},
{"wss://x.com/", "wss://x.com"},
{"x.com////", "wss://x.com"},
{"x.com/?x=23", "wss://x.com?x=23"},
{"localhost:4036", "ws://localhost:4036"},
{"localhost:4036/relay", "ws://localhost:4036/relay"},
{NormalizeURL("localhost:4036/relay"), "ws://localhost:4036/relay"},
}

func TestNormalizeURL(t *testing.T) {

// Output:
//
// wss://x.com/y
// wss://x.com/y
// ws://x.com/y
// ws://x.com/y
// wss://x.com
// wss://x.com
// wss://x.com
// wss://x.com
// wss://x.com
// wss://x.com
// wss://x.com?x=23
for _, test := range urlTests {
if output := NormalizeURL(test.url); output != test.expected {
t.Errorf("Output '%s' not equal to expected '%s'", output, test.expected)
}
}
}

0 comments on commit 8aaf5b8

Please sign in to comment.