Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+nip98.unpackEventFromToken +nip98.validateEvent #267

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

Airtune
Copy link
Contributor

@Airtune Airtune commented Aug 8, 2023

No description provided.

Copy link
Collaborator

@alexgleason alexgleason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful diff.

cc @Dolu89

Copy link
Contributor

@Dolu89 Dolu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the example? It's an error from me, it should be like this

await nip98.getToken('https://example.com/login', 'post', (e) => sign(e), true);

EDIT: on file nip98.ts line 23

@Airtune
Copy link
Contributor Author

Airtune commented Aug 8, 2023

Can you please update the example? It's an error from me, it should be like this

await nip98.getToken('https://example.com/login', 'post', (e) => sign(e), true);

EDIT: on file nip98.ts line 23

I updated the example and also updated the example for validation on line 63:

await nip98.validateToken('Nostr base64token', 'https://example.com/login', 'post')

Copy link
Contributor

@Dolu89 Dolu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update

@alexgleason alexgleason merged commit de7e128 into nbd-wtf:master Aug 8, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants