Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter: let tag queries be undefined #274

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

alexgleason
Copy link
Collaborator

The current type has this problem:

const filter: Filter = {};

// Uncaught TypeError: Cannot read properties of undefined (reading 'map')
filter['#e'].map(console.log)

All the keys in Filter are already optional with ?. To make tag queries optional we need | undefined

@fiatjaf fiatjaf merged commit e00362e into nbd-wtf:master Aug 12, 2023
1 check failed
@alexgleason alexgleason deleted the filter-type branch August 12, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants