-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Migrate to Minitest 5 and ActiveSupport 5 #143
Refactor: Migrate to Minitest 5 and ActiveSupport 5 #143
Conversation
a9156f9
to
c157df8
Compare
168be74
to
4b5e134
Compare
4b5e134
to
b3c5eb7
Compare
relates to #113 |
unit tests are failing in GitHub actions for AG but are passing locally. Is this ready for the review? |
I wasn't able to reproduce this unit test failure on my end with the seed. Is it failing for you when you run it locally? |
@alexskr - this is in response to a question you asked above:
Syphax submitted this pull request in response to a ticket I recently entered that details the difficulties of trying to work with the
Since Syphax was kind enough to submit a starting point for us, I think the onus should be on the BioPortal team to make a good faith effort to evaluate the code and try working out any issues on our end before asking for his assistance with troubleshooting. |
my intention is not to rush anyone but to state that the unit tests are passing on my end as far as I can tell. |
It wasn't my intention to imply that you're rushing anyone. Rather, I wanted to make sure Syphax's comments from the other ticket were included here. For anyone looking at this pull request, I thought it should be clear that this hasn't been fully deployed on their side, and may require some extra attention to get it fully integrated on our side. |
Context
This PR updates some gems versions to newer versions, which will help the support ruby >= 3 work (see ncbo/bioportal-project#275)
Changes
minitest
to version 5 and addminitest-hooks
to reproduce the existent before_suites and after_suites behavior no more existent inminitest
5activeSupport
to version 5Bigdecimal
andoj
gems