Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Migrate to Minitest 5 and ActiveSupport 5 #143

Merged

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented Mar 20, 2024

Context

This PR updates some gems versions to newer versions, which will help the support ruby >= 3 work (see ncbo/bioportal-project#275)

Changes

  • Migrate minitest to version 5 and add minitest-hooks to reproduce the existent before_suites and after_suites behavior no more existent in minitest 5
  • Upgrade activeSupport to version 5
  • Unpin Bigdecimal and oj gems

@syphax-bouazzouni syphax-bouazzouni force-pushed the pr/refactor/migrate-to-minitest-5 branch 2 times, most recently from a9156f9 to c157df8 Compare March 20, 2024 13:22
@syphax-bouazzouni syphax-bouazzouni marked this pull request as draft March 20, 2024 14:08
@syphax-bouazzouni syphax-bouazzouni force-pushed the pr/refactor/migrate-to-minitest-5 branch 4 times, most recently from 168be74 to 4b5e134 Compare March 21, 2024 17:23
@syphax-bouazzouni syphax-bouazzouni changed the base branch from master to develop March 21, 2024 19:18
@syphax-bouazzouni syphax-bouazzouni force-pushed the pr/refactor/migrate-to-minitest-5 branch from 4b5e134 to b3c5eb7 Compare March 21, 2024 19:20
@alexskr
Copy link
Member

alexskr commented Mar 21, 2024

relates to #113

@alexskr
Copy link
Member

alexskr commented Mar 27, 2024

unit tests are failing in GitHub actions for AG but are passing locally. Is this ready for the review?

@syphax-bouazzouni
Copy link
Author

unit tests are failing in GitHub actions for AG but are passing locally. Is this ready for the review?

The test failing is related to the order of tests. If you run the test locally with the same seed, you should the see the same errors.
image

Didn't figure out, what is the cause for now.

@alexskr
Copy link
Member

alexskr commented Mar 27, 2024

I wasn't able to reproduce this unit test failure on my end with the seed. Is it failing for you when you run it locally?

@jvendetti
Copy link
Member

@alexskr - this is in response to a question you asked above:

Is this ready for the review?

Syphax submitted this pull request in response to a ticket I recently entered that details the difficulties of trying to work with the ontologies_api project in Ruby 3, due to several outdated dependencies. Please note that he characterized the pull request as a starting point in this comment:

... just be aware, that I have not yet found time, to deploy it fully on our side, so take this PR with precaution, but I think at least it is a good starting point to the Minitest migration.

Since Syphax was kind enough to submit a starting point for us, I think the onus should be on the BioPortal team to make a good faith effort to evaluate the code and try working out any issues on our end before asking for his assistance with troubleshooting.

@alexskr
Copy link
Member

alexskr commented Mar 27, 2024

my intention is not to rush anyone but to state that the unit tests are passing on my end as far as I can tell.

@jvendetti
Copy link
Member

It wasn't my intention to imply that you're rushing anyone. Rather, I wanted to make sure Syphax's comments from the other ticket were included here. For anyone looking at this pull request, I thought it should be clear that this hasn't been fully deployed on their side, and may require some extra attention to get it fully integrated on our side.

@alexskr alexskr self-assigned this Sep 27, 2024
@alexskr alexskr merged commit e8301e6 into ncbo:develop Sep 28, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants