Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate recommender_v1 endpoint #166

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

alexskr
Copy link
Member

@alexskr alexskr commented Sep 28, 2024

Deprecate unused /recommender_v1 endpoint.

  • respond with 410 Gone status.
  • add a reminder to completely remove this in 1 year

@alexskr alexskr marked this pull request as ready for review September 28, 2024 02:38
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.33%. Comparing base (c2f1c58) to head (f089e32).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #166      +/-   ##
===========================================
- Coverage    73.39%   73.33%   -0.06%     
===========================================
  Files           53       53              
  Lines         2954     2948       -6     
===========================================
- Hits          2168     2162       -6     
  Misses         786      786              
Flag Coverage Δ
unittests 73.33% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants