Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds highlighting for "EBS Volume Not Encrypted" detail view #1629

Merged
merged 1 commit into from
May 8, 2024
Merged

Adds highlighting for "EBS Volume Not Encrypted" detail view #1629

merged 1 commit into from
May 8, 2024

Conversation

rieck-srlabs
Copy link
Contributor

Description

Highlights missing encryption for EBS volumes visually in ScoutSuite's detail view:

Screenshot 2024-04-17 at 09 54 52

Previously, the detail view dumped the full JSON object for EBS volumes and did not highlight the (missing) encryption visually (see issue #1628).

Addresses #1628

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

@fernando-gallego fernando-gallego self-assigned this May 8, 2024
@fernando-gallego fernando-gallego merged commit 6df2cfa into nccgroup:develop May 8, 2024
3 checks passed
@rieck-srlabs rieck-srlabs deleted the feature/1628-ebs-volume-detail-view-highlighting branch May 13, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants