-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add placeholder text to search bar #88
Comments
Looks like the Currently we can do a dirty workaround by passing an |
Looks like the location the prop would need to be added is SUPER nested since its all compiled. I think we should open up an issue. Line 69 in https://github.com/trussworks/react-uswds/blob/main/src/components/Search/Search.tsx is where it would need to be added. Alternatively, we could add the HTML that it renders to the |
I can open an issue if you'd like. It looks like a pretty easy fix on their end so I can submit a PR for it once an issue is created. @Dafondo |
I went ahead and opened the issue: trussworks/react-uswds#403 |
And I submitted a pr: trussworks/react-uswds#404 |
@SchaeStewart Sweet! Hopefully they turn it around quickly. |
Looks like it's released, we just need to upgrade our |
Currently the search only supports searching for Candidate by name, or contributors by name. We should add a placeholder text to the search bar explaining this
The text was updated successfully, but these errors were encountered: