Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Search component should support placeholder text #403

Closed
SchaeStewart opened this issue Aug 15, 2020 · 1 comment · Fixed by #415
Closed

[fix] Search component should support placeholder text #403

SchaeStewart opened this issue Aug 15, 2020 · 1 comment · Fixed by #415
Labels
type: bug Something isn't working like it's supposed to

Comments

@SchaeStewart
Copy link
Contributor

Does your feature request relate to a specific USWDS feature?
This project prioritizes work needed to gain full parity with the USWDS components and styles. If your feature request relates to a USWDS feature, please link it here and provide some context. If it doesn't, that's okay, but the request may be reprioritized accordingly.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Cannot add placeholder text to the search component.

Describe the solution you'd like
A clear and concise description of what you want to happen.

The Search component should accept a placeholder prop.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@SchaeStewart SchaeStewart added the type: feature New feature or request label Aug 15, 2020
@SchaeStewart
Copy link
Contributor Author

I'm happy to submit a PR for this, it seems like a relatively quick fix

@haworku haworku changed the title [feat] Search component should support placeholder text [fix] Search component should support placeholder text Aug 17, 2020
@haworku haworku added type: bug Something isn't working like it's supposed to and removed type: feature New feature or request labels Aug 17, 2020
haworku added a commit that referenced this issue Aug 18, 2020
Co-authored-by: Schaffer Stewart <schaestewart@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working like it's supposed to
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants