Make CI cached to speed up build times #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Oh, that’s cool. Quick question, though, are the changes in Edit: oh, it’s for Clippy, nvm |
osalbahr
approved these changes
Nov 19, 2023
|
Did you mean for the PR to merge as one commit? |
|
@Bennett-Petzold thoughts on enabling automatically deleting branches after the PR is merged? (it can still be restored if needed) |
|
@osalbahr Makes sense to me. I went ahead and enabled that in repo settings. And yes, single squashed commit was intentional (because there are waste commits in there...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our compile on CI is actually fairly fast, but this still saves some time on package install for the build command. Will save significantly more time on the clippy Action due to caching the compilation of the formatting tools.
The repository setting for clippy failures has also been escalated from errors to errors and warnings.