Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move from tui to ratatui #51

Merged
merged 2 commits into from
Mar 25, 2023
Merged

move from tui to ratatui #51

merged 2 commits into from
Mar 25, 2023

Conversation

ndd7xv
Copy link
Owner

@ndd7xv ndd7xv commented Mar 25, 2023

see fdehau/tui-rs#654 for more info

this also rebuilds the lock file; running a cargo tree -d --target all revealed a variety of dependencies that were being brought in with different versions, which now should not happen

this means smaller binary size (913408->909312 for windows) and less dependencies are built for heh to run (71->65 for windows, 68->66 for my local build)

this release of ratatui also improved the performance of split, so technically things should be slightly more performant lol

see fdehau/tui-rs#654 for more info

this also rebuilds the lock file; running a cargo tree -d --target all revealed a variety of dependencies that were being brought in with different versions, which now should not happen

this means smaller binary size (913408->909312 for windows) and less dependencies are built for heh to run (71->65 for windows, 68->66 for my local build)
@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Merging #51 (e00f549) into main (7fbccf6) will increase coverage by 5.3%.
The diff coverage is 100.0%.

Additional details and impacted files
Impacted Files Coverage Δ
src/screen.rs 22.8% <100.0%> (+22.8%) ⬆️

... and 1 file with indirect coverage changes

@ndd7xv ndd7xv merged commit 7c025df into main Mar 25, 2023
@ndd7xv ndd7xv deleted the ratatui branch July 26, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant