fix: add all data for submission versions

apollo/formsframework/forms.py

@@ -16,7 +16,7 @@
 ugly_phone = re.compile(r'[^\d]*')
 
 
-def update_submission_version(sender, document, **kwargs):
+def update_submission_version(phone, sender, document, **kwargs):
     if sender != services.submissions.__model__:
         return
 
@@ -42,10 +42,11 @@ def update_submission_version(sender, document, **kwargs):
 
     services.submission_versions.create(
         submission=document,
+        deployment=document.deployment,
         data=json.dumps(version_data),
         timestamp=datetime.utcnow(),
         channel=channel,
-        identity=g.get('phone', '')
+        identity=phone
     )
 
 

apollo/messaging/views_messaging.py

@@ -42,7 +42,7 @@ def lookup_participant(msg, event=None):
 
 def update_datastore(inbound, outbound, submission, had_errors):
     if submission:
-        update_submission.delay(str(submission.pk))
+        update_submission.delay(str(submission.pk), inbound.sender)
         participant = submission.contributor
     else:
         participant = lookup_participant(inbound)

apollo/submissions/tasks.py

@@ -1,4 +1,6 @@
 # -*- coding: utf-8 -*-
+from functools import partial
+
 from mongoengine import signals
 
 from apollo import models
@@ -27,15 +29,17 @@ def init_submissions(deployment_pk, event_pk, form_pk, role_pk,
 
 
 @celery.task
-def update_submission(submission_pk):
+def update_submission(submission_pk, sender):
     try:
         submission = models.Submission.objects.get(pk=submission_pk)
     except models.Submission.DoesNotExist:
         return
 
+    post_save_handler = partial(update_submission_version, sender)
+
     with signals.post_save.connected_to(
-            update_submission_version,
-            models.Submission):
+            post_save_handler,
+            sender=models.Submission):
         # save with precomputation enabled
         submission.save()