fix: prevent submitting decimal values in the PWA #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takinbo
requested changes
Jan 28, 2023
apollo/pwa/templates/pwa/index.html
Outdated
Comment on lines
841
to
843
| let errorMessage = '{{ _("Please check what you entered into the following fields") }}: ' + errorFields.join(); | ||
| let errorMessage = '{{ _("Please check that you did not enter a value out of bounds or a decimal number for the following question(s)") }}: ' + errorFields.join(); |
There was a problem hiding this comment.
I think we can leave the previous prompt; it's less verbose and possibly won't overburden the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the PR asks the user to review what they entered into a numeric data field in the PWA if it is not convertible to an exact integral value.
see: nditech/apollo-issues#199