-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Iskra IE.5 (Belgium) #153
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR! There are some tests which need to be fixed first |
Hi @ljehu, I just got the same smart meter installed but from another grid provider in Belgium (AIEG). Feel free to let me know :) Kind regards, Nicolas |
Hi @ndokter, I made some test of this change locally to try to understand why tests are failing. Current change in version information regex makes parser fail to retrieve the right line in the telegram data. My feeling is, after some debug, is that just changing the regex won't work with the way the parser works right now. Making the parser compatible with those regex groups is way above my current skills. So, sorry to bother you on this, but I want your advice before going further. Best regards, Nicolas |
Hi @anthares, sorry for the late response. I will try to get back to you |
@anthares you are right that the main problem is the tuple. Would something like this work? It fixes the tuple issue, but i'm not sure about the resulting values. The tests break in a different way: |
@anthares Would you be able to share a full Telegram for your meter so that we can compare it to the one we already have (from REW) in #152 (comment) ? I'd like to understand if we need to support two new version information (and equipment identifiers?), or if the ones from AIEG and REW are the same (but different from Fluvius apparently). |
Modified regex in obis_references.py to recognize multiple belgian devices.