cmake: Use external project for building cesium #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes-wolf
commented
Jul 4, 2024
ci/10_linux_build.bash
Outdated
|
|
||
| rm -rf build && mkdir build | ||
| cd build | ||
| mkdir deps | ||
| mkdir assets | ||
| emcmake cmake -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=OFF .. | ||
| cmake --build . -- -j | ||
| cmake --build . -- -j"$(nproc)" |
There was a problem hiding this comment.
Without specifying the job limit, the build fails if the env. CMAKE_GENERATOR is set to "Ninja".
|
Ok 👍 |
josephbirkner
approved these changes
Jul 10, 2024
johannes-wolf
force-pushed
the
cesium-build-external
branch
from
811c094 to
cc8d5e8
Compare
- Enables build using Ninja - Isolates build to prevent CMake target conflicts
johannes-wolf
force-pushed
the
cesium-build-external
branch
from
cc8d5e8 to
6d9487b
Compare
johannes-wolf
force-pushed
the
cesium-build-external
branch
from
aca86aa to
b592789
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows building erdblick using Ninja. The solution to build cesium using CMakes
ExternalProjectinstead ofFetchContentis a fixed version taken from #64.This PR also adds a
CMakePresets.json, that defines areleaseanddebugpreset. The build script call those presets. Presets make it easy defining CMake options for certain build-types and/or changing the build options locally without having to touch the shell scripts.