Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2024.4 #146

Merged
merged 111 commits into from
Sep 25, 2024
Merged

Release 2024.4 #146

merged 111 commits into from
Sep 25, 2024

Conversation

Waguramu
Copy link
Contributor

@Waguramu Waguramu commented Jul 30, 2024 •
edited
Loading

Goal: combine release 2024.4 PR.

Includes:

@Waguramu Waguramu self-assigned this Jul 30, 2024
@josephbirkner
Copy link
Collaborator

This PR also contains (partial?) implementations for picking search results, right?

josephbirkner
josephbirkner requested changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@josephbirkner josephbirkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't really work yet. Video from testing with landmarks.ndslive in our mapget-live-cpp test data directory:

Screencast from 2024-08-08 18-40-17.webm

erdblick_app/app/inspection.service.ts Outdated Show resolved Hide resolved
erdblick_app/app/view.component.ts Outdated Show resolved Hide resolved
libs/core/include/erdblick/geometry.h Outdated Show resolved Hide resolved
erdblick_app/app/view.component.ts Outdated Show resolved Hide resolved
@Waguramu
* Add bounding radius vector point
17d3755 
* Add KeyboardService
* Add zoom to feature shortcut
@Waguramu
* Add search history
0004876 
* Update search input
* Add resizable container
* Update actions and history entries to be selectable with keyboard
@Waguramu
Update search menu appearance with more icons and without tabView
dcaff06
@Waguramu
* Add coreLib getGeometryType
865b940 
* Add search result ID
* Refactoring
@Waguramu
* Add keyboard movement shortcuts
341742a 
* Add dialog escape functions
* Add tabbing across UI elements
@Waguramu
* Add M and R shortcuts
70de75e 
* Add multiple shortcuts per binding
* Refactor KeyboardService listener
@Waguramu Waguramu changed the title Zoom-to-Feature Functionality with Shortcut Release 2024.4 Sep 9, 2024
@Waguramu
Copy link
Contributor Author

Waguramu commented Sep 9, 2024 •
edited
Loading

General

  • Fix eslint build errors.

Keyboard Controls Fixes

  • Make sure tabbing through elements works consistently.
  • Add user guide on keyboard controls.

Search Fixes

  • Add delete entries for search results.
  • Remove duplicate entries.
  • UI fix for the search input bottom gap.
  • Improve textarea's focus on Ctrl-K.

Backlog

  • Make sure that Esc closes dialogs correctly in a stackable fashion.

josephbirkner and others added 24 commits September 18, 2024 17:37
@josephbirkner
Attach mapId to feature inspection nodes.
4c209ec
@josephbirkner
Merge pull request #157 from ndsev/datasource-config
00fa34e
@Waguramu
* Fix broken mobile layout.
e720a9a 
* Fix search and map panel layouts.
* Change appearance for style options.
* Collapse all style options by default for all disabled styles.
* Switch to boolean values for style options.
* Normalise checkbox sizes.
* Improve textarea focus on Ctrl-K.
* Retain inspection panels sizes.
* Improve tabbing in the maps panel.
* Parametrise camera movement.
@Waguramu
* Fix resizing inspection panels in Safari.
a41599c 
* Fix umlaut search entry.
* Cleanup unused imports.
* Fix coordinates panel in mobile layout.
@Waguramu
* Fix styles expand chevron states.
e477897 
* Add more constrains to source data buttons.
* Improve datasource config UI for error states.
@Waguramu
* Fix style export for Angular 18.
023f87b
@Waguramu
* Fix missing file uploader / conditional clickout for search panel.
9ce9a0e 
* Fix wrong button for imported styles.
* Bump version.
@josephbirkner
Fix mapId forwarding.
0a86574
@josephbirkner
Fix error display for SourceDataLayers
e77dfd3
@josephbirkner
Include current point in mergeCount.
317109e
@josephbirkner
Fix style options (plus missing changes for sourcedata error display).
5accfc3
@josephbirkner
Improvements for the datasource editor (without fix for layout and pr…
503bb18 
…eventing simultaneous opening).
@josephbirkner
Fix crash when resetting style.
44d756e
@josephbirkner
Fix style editor panel content.
fd4e677
@josephbirkner
Added loading screen.
e195be2
@josephbirkner
Fix merged-point mergeCount calculation.
e96e9a2
@josephbirkner
Fix labels for merged points.
b426d8c
@Waguramu
* Allow only a single editor.
c2d158e 
* Fix editor interface.
@Waguramu
* Fix fonts in inspection panel.
444d8fc 
* Add keyboard controls info.
@Waguramu
* Fix key controls button.
522e7f1 
* Restrict checkboxes to em-based size.
@MisterGC
deps: Fix mapget commit by using latest compatible one.
e26fd03
@Waguramu
* Update keyboard controls dialog CSS.
3499c89
@josephbirkner
Additional logic fixups for merged points in combination with labels.
d8f420a
@josephbirkner
Add label-text-expression to default style.
dfcadbc
@josephbirkner josephbirkner self-requested a review September 25, 2024 13:05
josephbirkner
josephbirkner approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@josephbirkner josephbirkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine!

@josephbirkner josephbirkner merged commit 0485b48 into main Sep 25, 2024
4 checks passed
@josephbirkner josephbirkner deleted the zoom-feature branch September 25, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephbirkner josephbirkner josephbirkner approved these changes

@MisterGC MisterGC Awaiting requested review from MisterGC

Assignees

@Waguramu Waguramu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Waguramu @josephbirkner @johannes-wolf @MisterGC