Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2024.4.1 #164

Merged
merged 40 commits into from
Nov 6, 2024
Merged

Release 2024.4.1 #164

merged 40 commits into from
Nov 6, 2024

Conversation

josephbirkner
Copy link
Collaborator

@josephbirkner josephbirkner commented Oct 17, 2024

  • Introduce a performance diagnostics dialog which may be opened via Ctrl+X
  • Fix occasional hanging updates by using mapget's new clientId instead of an HTTP abort.
  • Fix the visualization limit, which was blatantly ignored.

TODO:

  • Show number of aggregated tiles
  • Allow any integer/number tile info field to be viewed as a statistic.
  • Update statistics automatically (it should not be necessary to click "update").
  • Allow viewing render performance separately per style sheet and respective "hover"/"selection" modes.
  • Add a Button to open the dialog.
  • Do not generate hover highlights while the map is being dragged around.
  • Switch to synchronous geometry for tile borders as well.
  • Do not prematurely re-encode tiles when only a single one is rendered.
  • Statistics "Sum" column.

Closes #162

@josephbirkner josephbirkner changed the title Performance improvements Fix update jank and add performance diagnostics Oct 17, 2024
@josephbirkner
Copy link
Collaborator Author

josephbirkner commented Oct 25, 2024

Future TODOs (partially in other repos):

  • Add NDS.Live SmartLayer and DataLayer size and add network fetching wall-time statistics.
  • Ensure that region rule layers are not redundantly stored.
  • Implement two-stage loading: most fat attribute layers are only needed for search/inspection, but not for visualization.
  • Have some way of telling which parts of a TileFeatureLayer are occupying space.
  • Add some kind of loading progress visualization:
    • % of stage 1 layers received
    • % of stage 2 (add-on) layers received
    • % of finished tile visualizations

erdblick_app/app/keyboard.service.ts Outdated Show resolved Hide resolved
josephbirkner and others added 6 commits November 4, 2024 16:05
… JumpTargetService.

* Implement tile source data inspection target in JumpTargetService.
* Modify RightClickMenuService to use BehaviorSubject for menuItems management.
* Update SourceDataLayerSelectionDialogComponent with map/tile ID custom loading and tile outlining.
* Adjust ErdblickViewComponent to manage tile outlines and bind menu items.
* Increase width of context menu in styles.scss and add .red background style.
* Fix space characters in mapId and layerId for search menu entry
* Allow using layerName instead of layerId
@MisterGC
Copy link
Contributor

MisterGC commented Nov 4, 2024

Some improvements for the Viewport Statistics Dialog

  • Use floats only when it is applicable, otherwise int (e.g. number of features)
  • Add a tool tip to each entry so that users clearly know what the numbers indicate
  • Improve the labels - e.g. why do the render times for styles always contain -normal-, e.g. Number of Features instead of always the technical/tracking keyword
  • Would be quite useful to see which tilelayer caused a specific peak value - this would be quite helpful for detailed investigation
image

Copy link
Contributor

@MisterGC MisterGC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speed boost achieved! This PR is a significant step forward. Approved!

Although the improvements of the Viewport Statistics would help - I have compared cases which still cause performance problems - the peak sizes of the tiles where like 10x higher than ones in areas/viewports/maps (2 vs 20MB)

erdblick_app/app/features.model.ts Show resolved Hide resolved
@josephbirkner josephbirkner changed the title Fix update jank and add performance diagnostics Release 2024.4.1 Nov 5, 2024
@josephbirkner josephbirkner merged commit 471f78c into main Nov 6, 2024
2 checks passed
@josephbirkner josephbirkner deleted the performance-improvements branch November 6, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instrumentation and Responsiveness Improvements
3 participants