doc: validator structure change, state witness reference impl #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugachAG
reviewed
Jun 13, 2024
neps/nep-0509.md
Outdated
| * TBD | ||
|
|
||
| ## High level flow | ||
|
|
||
| We propose a change to the following parts of the chunk and block production flow: | ||
| The current high-level chunk production flow, if we drop details and edge cases, is as follows: |
There was a problem hiding this comment.
just FYI chat gpt suggested the following when I asked to make this sentence more idiomatic:
The current high-level chunk production flow, excluding details and edge cases, is as follows
pugachAG
reviewed
Jun 13, 2024
neps/nep-0509.md
Outdated
| * TBD | ||
|
|
||
| ## High level flow | ||
|
|
||
| We propose a change to the following parts of the chunk and block production flow: | ||
| The current high-level chunk production flow, if we drop details and edge cases, is as follows: | ||
| * Block producer at height H BP(H) produces block B(H) with chunks accessible to it and distributes it. |
There was a problem hiding this comment.
nit: I suggest highlighting expressions as code to make it easier to read:
Block producer at height H BP(H) produces block B(H)...
pugachAG
approved these changes
Jun 13, 2024
neps/nep-0509.md
Outdated
|
|
||
| ### New design | ||
|
|
||
| * Chunk producer, in addition to producing a chunk, produces new `ChunkStateWitness` message. The `ChunkStateWitness` contains data which is enough to prove validity of the chunk's header what is being produced. |
There was a problem hiding this comment.
nit: what is being produced -> that is being produced
neps/nep-0509.md
Outdated
| * A chunk validator, upon receiving a `ChunkStateWitness`, validates the state witness and determines if the chunk header is indeed correctly produced. If so, it sends a `ChunkEndorsement` to the current block producer. | ||
| * A `ChunkEndorsement` contains the chunk hash along with a signature proving the endorsement by the chunk validator. It implicitly carries a weight equal to the amount of the chunk validator's stake that is assigned to this shard for this block. (See Chunk Validator Shuffling). | ||
| * As the existing logic is today, the block producer for this block waits until either all chunks are ready, or a timeout occurs, and then proposes a block containing whatever chunks are ready. Now, the notion of readiness here is expanded to also having more than 2/3 of chunk endorsements by weight. |
There was a problem hiding this comment.
having more than 2/3 of chunk endorsements by weight. - unclear what "weight" means here, I suggest changing to "stake"
neps/nep-0509.md
Outdated
| * (Same as today) Do not require tracking any shard | ||
| * (Same as today) Should have a higher barrier of entry for security reasons (e.g. to make block double signing harder) | ||
| * (New) No longer require tracking any shard | ||
| * (Same as today) Should have a higher barrier of entry (to keep `BlockHeader` size low and for security reasons, to make block double signing harder) |
There was a problem hiding this comment.
how does " higher barrier of entry" helps with "to keep BlockHeader size low"? 🤔
neps/nep-0509.md
Outdated
| For the context of the NEP, it is enough to assume that `work_quality_ratio = avg_{role}({role}_quality_ratio)`. | ||
| So, if node is both a block and chunk producer, we compute quality for each role separately and then take average of them. | ||
|
|
||
| When epoch is finalized, all headers of blocks in it uniquely determine who was expected to produce each block and chunk. |
There was a problem hiding this comment.
nit: headers of blocks -> block headers
neps/nep-0509.md
Outdated
| Field structure doesn't change, but we need to carefully pick range of set of source chunks, so different subsets will cover all source receipts without intersection. | ||
|
|
||
| Let's say B2 is the block that contains the last new chunk of shard S before chunk which state transition we execute, and B1 is the | ||
| block that contains the last new chunk of shard S before B2. |
There was a problem hiding this comment.
nit: you don't need line break here
|
Sorry I won't have time to review today, feel free to merge to reduce the chance of merge conflicts with others. If I have any nits I'll just send a follow up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documenting changes to validators and describing basics of reference implementation.