-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release #143
chore: release #143
Conversation
d94d8bf
to
b8d23c2
Compare
@MarcoIeni I probably need your help to understand what is going on here. There were only 5 commits since v0.10.3: borsh-v0.10.3...master, but the CHANGELOG picks up older commits as well. Is there a way to fix it? |
@MarcoIeni Another thing that bothers me is the reported versions. What is "(β API compatible changes)"? |
b8d23c2
to
a24aaee
Compare
Release-plz doesn't like the To fix this, just update the version (if v0.11.0 isn't correct) and the changelog of this PR manually and then merge the PR (when you want to release the new version). This error shouldn't happen again in the future because now the
That's because git-cliff analyzes the tags, while release-plz compares the single commits with what's published in crates.io.
It's the outcome of cargo-semver-checks. It means that the tool didn't identify breaking changes in your library code. You can disable the check with this config field.
That's a bug I fixed in MarcoIeni/release-plz#802 Thanks for the bug report π |
I released the new release-plz version π |
Co-authored-by: release-plz <release-plz@github.com>
@MarcoIeni I am sorry to bother you again, but the next release initially constructed a correct CHANGELOG and properly suggested to cut 0.11.1 release (see the history of changes of that PR description), but with one more commit to master, it broke the CHANGELOG (exploded with old changes) and now it suggests to cut 0.12.0 release which and I don't understand why (I expected #142 to be a non-breaking change). Also, I don't understand how to read those "(β API compatible changes)" notes - borsh-derive is the only package that does not have the note:
|
Oops, apparently there's an issue with symlinks π
No worries at all, thanks for pinging me when you find issues in release-plz. It helps me making it better :)
I created MarcoIeni/release-plz#811 I think borsh-derive is not checked because it's a proc-macro. But this is just a guess π€ |
Hi Vlad! Some news from me:
I tested Again, thanks for your patience, and for reporting issues π |
@MarcoIeni Thanks for all your support! I am breaking your tool with our obscure cases almost daily π This time we yanked the most recent version and now release-plz does not pick new commits to master as candidates to the new release: https://github.com/near/borsh-rs/actions/runs/5277864683/jobs/9546500990 |
Hi! Have you looked at https://marcoieni.github.io/release-plz/extra/yanked-packages.html ? |
@MarcoIeni Thanks for the pointer! |
π€ New release
borsh
: 0.10.3 -> 0.11.0 (β API compatible changes)borsh-derive
: 0.10.3 -> 0.10.4borsh-derive-internal
: 0.10.3 -> 0.11.0 (β API compatible changes)borsh-schema-derive-internal
: 0.10.3 -> 0.10.4 (β API compatible changes)Changelog
borsh
This PR was generated with release-plz.