Add `#[borsh(use_discriminant = <bool>)]` that change enum discriminant de- and serialization behavior #148 #183

iho · 2023-07-27T12:09:26Z

Addressing #138 (comment)

Resolves #147

I closed previous PR #148 because it has too much commits and I had problem with rebasing master

borsh-derive/src/lib.rs

borsh-derive-internal/src/attribute_helpers.rs

borsh-derive-internal/src/enum_ser.rs

borsh-derive-internal/src/enum_de.rs

borsh-derive-internal/src/enum_ser.rs

Co-authored-by: dj8yf0μl <26653921+dj8yfo@users.noreply.github.com>

…' into iho_enum_discriminant_attr_macros_2

borsh-derive-internal/src/attribute_helpers.rs

Co-authored-by: dj8yf0μl <26653921+dj8yfo@users.noreply.github.com>

…' into iho_enum_discriminant_attr_macros_2

borsh-derive-internal/src/enum_de.rs

borsh-derive-internal/src/enum_ser.rs

README.md

Co-authored-by: dj8yf0μl <26653921+dj8yfo@users.noreply.github.com>

borsh-derive/src/lib.rs

borsh/tests/test_simple_structs.rs

Co-authored-by: dj8yf0μl <26653921+dj8yfo@users.noreply.github.com>

frol

@iho I have updated the README. Thanks for pushing it forward! This PR looks good to me, but I still defer the final decision here to @dj8yfo.

.github/workflows/rust.yml

…' into iho_enum_discriminant_attr_macros_2

dj8yfo · 2023-07-31T12:48:31Z

this is a formal proof that behavior of 0.10.3 is identical to this pr - https://github.com/iho/borsh-test.
It's not fully automated, requires edits to switch from one version of borsh to another and test against the same snapshots.

borsh-derive/src/lib.rs

.github/workflows/rust.yml

iho added 2 commits July 27, 2023 15:08

WIP

b1a029f

Update insta snapshots

46d5d99

iho requested review from frol and dj8yfo as code owners July 27, 2023 12:09

iho added 6 commits July 27, 2023 15:17

clippy

cd178dc

clippy

a9634e2

Add documentation

889d3de

remove debug prints; add documentation

ae73c13

fix doc

09f2872

remove debug print

293e3c8

dj8yfo requested changes Jul 27, 2023

View reviewed changes

iho marked this pull request as draft July 27, 2023 16:12

iho and others added 8 commits July 27, 2023 19:12

Apply suggestions from code review

4e820fe

Co-authored-by: dj8yf0μl <26653921+dj8yfo@users.noreply.github.com>

Merge remote-tracking branch 'iho/iho_enum_discriminant_attr_macros_2…

a1ea2e4

…' into iho_enum_discriminant_attr_macros_2

Add test; bump Rust version in CI; fix typos

b952d94

refactoring

20a5063

Apply suggestion for check_item_attributes

e58f45b

Add docs for

80bf4e8

remove comment; add documentation

6516978

clippy

bfddc0c

dj8yfo requested changes Jul 27, 2023

View reviewed changes

borsh-derive-internal/src/attribute_helpers.rs Outdated Show resolved Hide resolved

dj8yfo requested changes Jul 27, 2023

View reviewed changes

borsh-derive-internal/src/attribute_helpers.rs Outdated Show resolved Hide resolved

dj8yfo requested changes Jul 27, 2023

View reviewed changes

borsh-derive-internal/src/attribute_helpers.rs Outdated Show resolved Hide resolved

iho and others added 3 commits July 27, 2023 21:27

replace panic in macros to explicit error

6769a32

Apply suggestions from code review

d02b68e

Co-authored-by: dj8yf0μl <26653921+dj8yfo@users.noreply.github.com>

Merge remote-tracking branch 'iho/iho_enum_discriminant_attr_macros_2…

4268247

…' into iho_enum_discriminant_attr_macros_2

dj8yfo requested changes Jul 27, 2023

View reviewed changes

borsh-derive-internal/src/enum_de.rs Show resolved Hide resolved

borsh-derive-internal/src/enum_ser.rs Show resolved Hide resolved

dj8yfo requested changes Jul 27, 2023

View reviewed changes

README.md Outdated Show resolved Hide resolved

fix test

3a9a314

dj8yfo mentioned this pull request Jul 28, 2023

(not for merge, discussion comments) enum discriminant de- and serialization behavior #148

Closed

iho and others added 4 commits July 28, 2023 20:41

Add documentation; Bump Rust compiler version

ed91c8f

Apply suggestions from code review

5a37fc5

Co-authored-by: dj8yf0μl <26653921+dj8yfo@users.noreply.github.com>

Fix tests

2b0266b

Fix test; clippy

52e5550

dj8yfo requested changes Jul 29, 2023

View reviewed changes

borsh/tests/test_simple_structs.rs Outdated Show resolved Hide resolved

iho and others added 3 commits July 30, 2023 14:54

Apply suggestions from code review

dbb1338

Co-authored-by: dj8yf0μl <26653921+dj8yfo@users.noreply.github.com>

Move enum related tests to separate file

a99c500

fix doc CI

0a342a5

iho requested a review from dj8yfo July 30, 2023 12:11

iho marked this pull request as ready for review July 30, 2023 12:11

docs: Update "Enum with explicit discriminant" README.md

b5cb18c

frol approved these changes Jul 30, 2023

View reviewed changes

dj8yfo requested changes Jul 31, 2023

View reviewed changes

.github/workflows/rust.yml Show resolved Hide resolved

iho added 2 commits July 31, 2023 11:47

fix(ci): conditional downgrade of time for older toolchain

dbd3382

Merge remote-tracking branch 'iho/iho_enum_discriminant_attr_macros_2…

64af896

…' into iho_enum_discriminant_attr_macros_2

dj8yfo requested changes Jul 31, 2023

View reviewed changes

borsh-derive/src/lib.rs Outdated Show resolved Hide resolved

borsh-derive/src/lib.rs Outdated Show resolved Hide resolved

borsh-derive/src/lib.rs Outdated Show resolved Hide resolved

borsh-derive/src/lib.rs Outdated Show resolved Hide resolved

dj8yfo requested changes Jul 31, 2023

View reviewed changes

borsh-derive/src/lib.rs Outdated Show resolved Hide resolved

frol reviewed Jul 31, 2023

View reviewed changes

.github/workflows/rust.yml Outdated Show resolved Hide resolved

frol and others added 4 commits July 31, 2023 15:57

ci: fixed the condition on when to downgrade time crate in CI workflow

01db1f4

Fix English in doc

144ffaf

chore: revert unneeded imports reordering

f242f2e

chore: duplicate if let Err(...) instead of match

d6fdb9e

dj8yfo approved these changes Jul 31, 2023

View reviewed changes

dj8yfo merged commit 3db1c31 into near:master Jul 31, 2023
7 checks passed

dj8yfo mentioned this pull request Jul 31, 2023

Introduce a required #[borsh(use_discriminant = true|false)] enum attribute when discriminants are specified #147

Closed

frol mentioned this pull request Aug 7, 2023

chore: release #146

Merged

dj8yfo changed the title ~~Add borsh macros that change enum discriminant de- and serialization behavior #148~~ Add #[borsh(use_discriminant = <bool>)] that change enum discriminant de- and serialization behavior #148 Aug 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `#[borsh(use_discriminant = <bool>)]` that change enum discriminant de- and serialization behavior #148 #183

Add `#[borsh(use_discriminant = <bool>)]` that change enum discriminant de- and serialization behavior #148 #183

iho commented Jul 27, 2023 •

edited by frol

Loading

frol left a comment

dj8yfo commented Jul 31, 2023

Add #[borsh(use_discriminant = <bool>)] that change enum discriminant de- and serialization behavior #148 #183

Add #[borsh(use_discriminant = <bool>)] that change enum discriminant de- and serialization behavior #148 #183

Conversation

iho commented Jul 27, 2023 • edited by frol Loading

frol left a comment

Choose a reason for hiding this comment

dj8yfo commented Jul 31, 2023

Add `#[borsh(use_discriminant = <bool>)]` that change enum discriminant de- and serialization behavior #148 #183

Add `#[borsh(use_discriminant = <bool>)]` that change enum discriminant de- and serialization behavior #148 #183

iho commented Jul 27, 2023 •

edited by frol

Loading