refactor!: Unsplit and removal of *-internal crates

[iho]

this is fraction of #51

[dj8yfo]

• the following is the target module structure for this pr:

# ❯ erd --pattern '.*\.rs' --suppress-size -y inverted
 borsh-derive
 └─ src
    ├─ internals.rs
    ├─ lib.rs
    └─ internals
       ├─ generics.rs
       ├─ serialize
       │  ├─ union
       │  │  └─ mod.rs
       │  ├─ struct
       │  │  └─ mod.rs
       │  ├─ mod.rs
       │  └─ enum
       │     └─ mod.rs
       ├─ schema
       │  ├─ struct
       │  │  └─ mod.rs
       │  ├─ mod.rs  # borsh-schema-derive-internal/src/schema_helpers.rs content => src/internals/schema/mod.rs,  
       │  └─ enum
       │     └─ mod.rs
       ├─ enum_discriminant_map.rs
       ├─ deserialize
       │  ├─ union
       │  │  └─ mod.rs
       │  ├─ struct
       │  │  └─ mod.rs
       │  ├─ mod.rs
       │  └─ enum
       │     └─ mod.rs
       ├─ attributes
       │  ├─ mod.rs
       │  ├─ field
       │  │  ├─ schema.rs
       │  │  ├─ schema
       │  │  │  └─ with_funcs.rs
       │  │  ├─ mod.rs
       │  │  └─ bounds.rs
       │  └─ parsing.rs
       └─ test_helpers.rs

The same outline is also present in this repo

[dj8yfo]

• the following is the target tests modules structure of this pr:

 borsh-derive
 └──src
    ├──internals
    │  ├──attributes
    │  │  ├──field
    │  │  │  └──mod.rs
    │  │  │     └──#[cfg(test)]
    │  │  └──mod.rs
    │  │     └──#[cfg(test)]
    │  ├──deserialize
    │  │  ├──enum
    │  │  │  └──mod.rs
    │  │  │     └──#[cfg(test)]
    │  │  └──struct
    │  │     └──mod.rs
    │  │        └──#[cfg(test)]
    │  ├──schema
    │  │  ├──enum
    │  │  │  └──mod.rs
    │  │  │     └──#[cfg(test)]
    │  │  └──struct
    │  │     └──mod.rs
    │  │        └──#[cfg(test)]
    │  └──serialize
    │     ├──enum
    │     │  └──mod.rs
    │     │     └──#[cfg(test)]
    │     └──struct
    │        └──mod.rs
    │           └──#[cfg(test)]
    └──internals.rs
       └──#[cfg(test)]  # these aren't tests, it's `pub mod test_helpers;`

src/internals/attributes/field/mod.rs is needed instead of src/internals/attributes/field.rs , as insta crate has a nice feature of placing snapshots folder in the same folder as file containing tests, which create these snapshots,
so it will become src/internals/attributes/field/snapshots folder for tests in specifically src/internals/attributes/field/mod.rs,
which will allow to split up the total of 111 snapshots into small groups close to their corresponding tests.

[dj8yfo]

the following are some commands to simplify bookkeeping to make sure that probably all of tests/snapshots have been
transferred and not duplicated, though the module paths will change and strings for arguments of grep will too. (the initial version of this pr has transferred 36 borsh-schema-derive-internal snapshots twice, resulting in 147 snapshots total instead of 75 + 36 = 111)

• borsh-derive-internal - 73 tests

  • cargo nextest list --features schema | grep attribute_helpers | wc -l # 25
  • cargo nextest list --features schema | grep enum_de | wc -l # 11
  • cargo nextest list --features schema | grep enum_ser | wc -l # 13
  • cargo nextest list --features schema | grep struct_de | wc -l # 11
  • cargo nextest list --features schema | grep struct_ser | wc -l # 13

• borsh-schema-derive-internal - 36 tests

  • cargo nextest list --features schema | grep struct_schema | wc -l # 22
  • cargo nextest list --features schema | grep enum_schema | wc -l # 14

• borsh-derive-internal - 75 snapshots

  • fd 'attribute_helpers.*\.snap' | wc -l # 27
  • fd 'enum_de.*\.snap' | wc -l # 11
  • fd 'enum_ser.*\.snap' | wc -l # 13
  • fd 'struct_de.*\.snap' | wc -l # 11
  • fd 'struct_ser.*\.snap' | wc -l # 13

• borsh-schema-derive-internal - 36 snapshots

  • fd 'enum_schema.*\.snap' | wc -l # 14
  • fd 'struct_schema.*\.snap' | wc -l # 22

[iho]

I changed structure, so you need to use different commands:

cargo nextest list --features schema 2>/dev/null| grep attributes | wc -l
cargo nextest list --features schema 2>/dev/null| grep deserialize::enums  | wc -l
cargo nextest list --features schema 2>/dev/null| grep internals::serialize::enums  | wc -l
cargo nextest list --features schema 2>/dev/null| grep deserialize::structs  | wc -l
cargo nextest list --features schema 2>/dev/null| grep internals::serialize::structs  | wc -l
echo #####

cargo nextest list --features schema 2>/dev/null| grep internals::schema::structs  | wc -l
cargo nextest list --features schema 2>/dev/null| grep  internals::schema::enums  | wc -l

echo #####
ls src/internals/attributes/item/snapshots | wc -l
ls src/internals/attributes/field/snapshots | wc -l

ls src/internals/deserialize/enums/snapshots | wc -l
ls src/internals/serialize/enums/snapshots | wc -l
ls src/internals/deserialize/structs/snapshots | wc -l
ls src/internals/serialize/structs/snapshots | wc -l
echo #####
ls src/internals/schema/enums/snapshots | wc -l
ls src/internals/schema/structs/snapshots | wc -l

[dj8yfo]

Added commit to simplify potential funeral of schema feature (with honours and three-volley salute).

[frol]

@iho Thanks for the dedicated work!

@dj8yfo Thanks for the thorough code reviews