Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: nearcore migration guide to 1.0.0 #198

Merged
merged 2 commits into from
Oct 3, 2023
Merged

doc: nearcore migration guide to 1.0.0 #198

merged 2 commits into from
Oct 3, 2023

Conversation

dj8yfo
Copy link
Collaborator

@dj8yfo dj8yfo commented Aug 16, 2023

Md file is description of changes within borsh update in nearcore

@dj8yfo dj8yfo force-pushed the nearcore_mg branch 5 times, most recently from f4a09ce to e3cf1da Compare August 16, 2023 18:41
borsh/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it is all great, but I want to mention that when I suggested having a migration guide I meant to write one for those who will need to migrate their projects to borsh 1.0.0, so the value is not that we teach people how to migrate nearcore to use borsh 1.0.0, but rather use nearcore to capture all the possible issues on that way and document them.

migration_guides/v0.10.2_to_v1.0.0_nearcore.md Outdated Show resolved Hide resolved
migration_guides/v0.10.2_to_v1.0.0_nearcore.md Outdated Show resolved Hide resolved
migration_guides/v0.10.2_to_v1.0.0_nearcore.md Outdated Show resolved Hide resolved
migration_guides/v0.10.2_to_v1.0.0_nearcore.md Outdated Show resolved Hide resolved
migration_guides/v0.10.2_to_v1.0.0_nearcore.md Outdated Show resolved Hide resolved
@frol
Copy link
Collaborator

frol commented Aug 16, 2023

@dj8yfo I have just cut 1.0.0-alpha.3 release with #[borsh(skip)], which I believe will break more code in nearcore. Could you take a look, and update the PR and this guide?

@dj8yfo dj8yfo force-pushed the nearcore_mg branch 4 times, most recently from abed9d5 to 0d346f1 Compare August 18, 2023 12:53
@dj8yfo dj8yfo force-pushed the nearcore_mg branch 8 times, most recently from 621c80b to 7cfc554 Compare September 10, 2023 19:04
@dj8yfo dj8yfo force-pushed the nearcore_mg branch 2 times, most recently from 3a314ad to 993faf7 Compare October 2, 2023 17:46
@dj8yfo dj8yfo force-pushed the nearcore_mg branch 2 times, most recently from 9f90afe to ff3bcd1 Compare October 2, 2023 18:05
@dj8yfo dj8yfo marked this pull request as ready for review October 2, 2023 18:19
@dj8yfo dj8yfo requested a review from frol October 2, 2023 18:28
@frol frol merged commit 773827c into master Oct 3, 2023
7 checks passed
@frol frol deleted the nearcore_mg branch October 3, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants