Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: deprecate try_to_vec method from BorshSerialize #206

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

dj8yfo
Copy link
Collaborator

@dj8yfo dj8yfo commented Aug 23, 2023

Part of #51 resolution.

This pr addresses the following comment of review.
tmp

Logically this pr is part of #205 , but as the removal of this commonly used api caused moderate amout of changes, it was made a separate pr to be declined or approved separately from #205.

@dj8yfo dj8yfo force-pushed the serialize_try_to_vec_remove branch 3 times, most recently from d8c72a8 to db732b1 Compare August 23, 2023 14:20
@dj8yfo dj8yfo marked this pull request as ready for review August 23, 2023 14:26
@dj8yfo dj8yfo requested a review from frol as a code owner August 23, 2023 14:26
@dj8yfo dj8yfo force-pushed the serialize_try_to_vec_remove branch from db732b1 to 1f3eab0 Compare August 24, 2023 18:59
@dj8yfo dj8yfo marked this pull request as draft August 29, 2023 13:21
@dj8yfo dj8yfo force-pushed the serialize_try_to_vec_remove branch 2 times, most recently from 2462ed9 to 8bb5d6d Compare August 29, 2023 13:58
@dj8yfo dj8yfo changed the title chore!: remove try_to_vec method from BorshSerialize chore!: deprecate try_to_vec method from BorshSerialize Aug 29, 2023
@dj8yfo dj8yfo marked this pull request as ready for review August 29, 2023 14:13
@dj8yfo dj8yfo merged commit 47e268e into master Aug 29, 2023
7 checks passed
@dj8yfo dj8yfo deleted the serialize_try_to_vec_remove branch August 29, 2023 14:43
@frol frol mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants