feat(source-scan): logging, refactor, image with same cargo-near embedded, remove --no-docker flag
#144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 9, 2024 18:52
dj8yfo
force-pushed
the
source-scan-configure-build-command
branch
3 times, most recently
from
ebcbadc
to
7f4e5d1
Compare
dj8yfo
force-pushed
the
source-scan-configure-build-command
branch
from
5127c38
to
ebf8963
Compare
dj8yfo
changed the title
cargo near buildcargo-near embedded, remove --no-docker flag
dj8yfo
changed the title
cargo-near embedded, remove --no-docker flagcargo-near embedded, remove --no-docker flag
dj8yfo
changed the title
cargo-near embedded, remove --no-docker flagcargo-near embedded, remove --no-docker flag
dj8yfo
force-pushed
the
source-scan-configure-build-command
branch
from
87c32fa
to
ca224e3
Compare
frol
approved these changes
Apr 13, 2024
| let docker_image = docker_build_meta.concat_image(); | ||
| let near_build_env_ref = format!("NEAR_BUILD_ENVIRONMENT_REF={}", docker_image); | ||
|
|
||
| // Platform-specific UID/GID retrieval |
There was a problem hiding this comment.
This is a pretty pointless comment. More useful comment would be to explain that we only really need to match uid/gid on Linux since Docker is running natively and mounted FS needs to have proper permissions.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following output was generated by using the branch of current pr with build local
cargo-nearDockerfile => image on this repo