feat(source-scan): similar behaviour of build destination with --no-docker flow
#153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj8yfo
changed the title
--no-docker flow--no-docker flow
added 2 commits
April 22, 2024 11:14
dj8yfo
force-pushed
the
source-scan-build-destination
branch
from
9d8c116
to
9318292
Compare
frol
approved these changes
Apr 23, 2024
Comment on lines
+88
to
+114
| for entry in dir.flatten() { | ||
| if entry | ||
| .path() | ||
| .extension() | ||
| .unwrap_or(OsStr::new("not_wasm")) | ||
| .to_str() | ||
| .unwrap_or("not_wasm") | ||
| == "wasm" | ||
| { | ||
| let out_wasm_path = { | ||
| let filename = entry | ||
| .path() | ||
| .file_name() | ||
| .unwrap() | ||
| .to_string_lossy() | ||
| .into_owned(); | ||
| destination_dir.push(filename); | ||
| destination_dir | ||
| }; | ||
| if out_wasm_path.exists() { | ||
| println!(" {}", "removing previous artifact".cyan()); | ||
| std::fs::remove_file(&out_wasm_path)?; | ||
| } | ||
| std::fs::copy::<std::path::PathBuf, camino::Utf8PathBuf>( | ||
| entry.path(), | ||
| out_wasm_path.clone(), | ||
| )?; |
There was a problem hiding this comment.
Ideally, we should resolve the wasm file name from Cargo metadata and don't search wasm files in the target folder as that might be a wrong wasm file after all.
frol
pushed a commit
that referenced
this pull request
Apr 24, 2024
this addresses #153 (comment) screenshot from https://github.com/dj8yfo/sample_no_workspace/tree/metadata_image_repo_build_cmd 
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following has been compared to
--no-dockercounterparts,they produce the same output
*.wasmpaths (*.jsonand*.zstaren't producedas result of a build).
Tested on https://github.com/dj8yfo/sample_no_workspace/tree/set_metadata_with_repo .
cargo near build --no-abicargo near buildcargo near deploycargo near build --no-abi --out-dir /path/to/tmp_build_destinationcargo near build --out-dir /path/to/tmp_build_destinationcargo near deploy --out-dir /path/to/tmp_build_destination