Simple NFT #129
Closed
Simple NFT #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikedotexe
reviewed
Mar 10, 2021
mikedotexe
reviewed
Mar 10, 2021
mikedotexe
reviewed
Mar 10, 2021
evgenykuzyakov
requested review from
bowenwang1996 and
willemneal
as code owners
Co-authored-by: Bowen Wang <bowenwang1996@users.noreply.github.com>
mikedotexe
reviewed
Mar 15, 2021
|
This PR should be against |
* nft-simple: add metadata for token and contract, for init and minting fns, and nft_metadata fn * update nft_simple WASM file
…er (#135) * update add callback to approvals with NonFungibleTokenApprovalsReceiver * allow passing of deposit > 1 yocto when approve account id * remove revoke_all callback and fix args * finalized on_approve/revoke callbacks * standards updates, enforce approval_id nonce, update nameing, remove revoke_approval callback * fire approval callback no matter what * clean up interface and deposit issues * no bump approval on internal_transfer * review edits OMG * nft_approve: if account is already approver, don't check for attached deposit, refund if given * add optional promise to nft_approve, fix approval id per entry via HashMap, add TokenReturnObject * correct u64s that need to be U64 * nft-simple: add 6 basic unit tests * review edits: remove return val on nft_approve, update sizing for hashmap * remove as_return * simplify Token struct, use U64, remove unnecessary helpers * nft-simple: add exquisite corpse and simulation tests, ft wasm * nft-simple: add to simulation tests w/ exquisite corpse to demonstrate nft_approve * Rework NFT simple contract * use near-sdk 3.1.0, simplify sim tests to use basic test-nft contract Co-authored-by: Mike Purvis <mikedotexe@gmail.com> Co-authored-by: Evgeny Kuzyakov <ek@nearprotocol.com>
We're trying to stick with the merged spec on this one, thanks tho! It is slightly odd |
|
Updated the initial description of this PR with changes I think we need before merging. |
|
Closing in favor of putting this in the contract standards in the sdk near/near-sdk-rs#361 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining items as I see it:
NonFungibleTokenCoretrait has mixed other standards in there, including approvals and enumeration. Let's separate these into different traits and corresponding files.