-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: throw if no account exists #102
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
const parsedUrl = new URL(failure_url || success_url || window.location.origin + (basePath ? `/${basePath}` : '')); | ||
parsedUrl.searchParams.set('code', error.code); | ||
parsedUrl.searchParams.set('reason', message); | ||
window.location.replace(parsedUrl.href); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this part of code gets repeated multiple times, is it possible if we pull this into a util function and repeat on other areas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest looks good. Just comment on refactoring.
Throw in the following cases: