Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo + Playwright e2e tests scaffolding #108

Merged
merged 11 commits into from
Nov 9, 2023
Merged

Conversation

MaximusHaximus
Copy link
Contributor

@MaximusHaximus MaximusHaximus commented Nov 9, 2023

  • Refactored codebase to be a Yarn workspaces monorepo. Existing code was moved into packages/near-fast-auth-signer
  • Added new package near-fast-auth-signer-e2e-tests, which will contain Playwright e2e tests that run against the version of near-fast-auth-signer on the same git commit hash, linked using yarn workspaces.
  • Updated existing github workflows to work with sub-package
  • Added new Playwright github workflow

Note that because files have been moved around the filesystem drastically, any work in-progress on your local dev machine will likely need to be re-applied after pulling this code.

Closes #101

cc: @esaminu @trechriron

Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fast-auth-signer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 4:13pm

@MaximusHaximus MaximusHaximus changed the title [WIP] Lerna + Playwright [WIP] Monorepo + Playwright e2e tests Nov 9, 2023
@MaximusHaximus MaximusHaximus changed the title [WIP] Monorepo + Playwright e2e tests [WIP] Monorepo + Playwright e2e tests scaffolding Nov 9, 2023
@MaximusHaximus MaximusHaximus changed the title [WIP] Monorepo + Playwright e2e tests scaffolding Monorepo + Playwright e2e tests scaffolding Nov 9, 2023
Copy link
Collaborator

@esaminu esaminu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaximusHaximus MaximusHaximus merged commit 6079e80 into main Nov 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to mono-repo
2 participants