Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lint workflow #79

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Added lint workflow #79

merged 3 commits into from
Oct 20, 2023

Conversation

DamirSQA
Copy link
Collaborator

@DamirSQA DamirSQA commented Oct 9, 2023

Added PR workflow that checks for lint errors and blocks merging if there's lint issues present. Lint fixes included.

@vercel
Copy link

vercel bot commented Oct 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fast-auth-signer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 1:58pm

@DamirSQA DamirSQA linked an issue Oct 10, 2023 that may be closed by this pull request
@DamirSQA DamirSQA requested a review from esaminu October 10, 2023 11:47
Copy link
Contributor

@MaximusHaximus MaximusHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, let's get this landed, but please keep our react 'no array index as key' rule enabled and fix the code occurences that break this rule instead of disabling it.

.eslintrc.js Outdated Show resolved Hide resolved
Copy link
Contributor

@MaximusHaximus MaximusHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 :)

@DamirSQA DamirSQA merged commit ff76dfc into main Oct 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add lint workflow
2 participants