feat: add support for non webauthn browsers #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hcho112
requested changes
Oct 15, 2023
There was a problem hiding this comment.
I have conducted the test against this part of code on Firefox and unfortunately it doesn't work. As part of communicating to relayer, we are expected to have keypair that will be used to create signature (https://github.com/near/mpc-recovery)
This PR is currently not working because it is missing keypair on firefox environment.
I will work on the fix and push to this PR shortly
|
@esaminu I'm still working on the flow of when max key reached path on top of this PR |
esaminu
force-pushed
the
support-non-webauthn-browsers
branch
from
81cae71 to
822130f
Compare
hcho112
previously approved these changes
Oct 24, 2023
This was referenced Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #87