fix: pass firebase aud id to signer node #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaoticTempest
approved these changes
Apr 26, 2023
| @@ -289,7 +289,10 @@ async fn new_account<T: OAuthTokenVerifier>( | |||
| ); | |||
|
|
|||
| match process_new_account::<T>(state, request).await { | |||
| Ok(response) => (StatusCode::OK, Json(response)), | |||
| Ok(response) => { | |||
| tracing::debug!("responding with OK"); | |||
There was a problem hiding this comment.
do we still need this log call? If we do, let's differentiate it from the other one below just so we can tell which is which if we need it
There was a problem hiding this comment.
yeah I think it will help to clearly see at which point the call succeeded. They are differentiated by the span they are in (that instrument macro adds it).
|
Yeah, the hardest problem in programming is naming :) naming the errors in this case |
itegulov
added a commit
that referenced
this pull request
Apr 26, 2023
Co-authored-by: Serhii Volovyk <SergeyVolovyk@gmail.com> Co-authored-by: DavidM-D <dmillardurrant@gmail.com> Co-authored-by: Phuong Nguyen <ChaoticTempest@users.noreply.github.com> fix: pass firebase aud id to signer node (#143)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.