Signing flow explained in README #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Dev EnvironmentTerraform Format and Style 🖌
|
Terraform Feature Environment (dev-265)Terraform Initialization ⚙️
|
hcho112
reviewed
Aug 17, 2023
| 2. Client fetches latest nonce, block hash using obtained recovery PK. | ||
| 3. Client creates a delegate action with desired actions, such as add or delete key. | ||
| 4. Client gets the signature from the MPC system using `/sign` endpoint. | ||
| 5. Client sends the same delegate action to the relayer with obtained signature. |
There was a problem hiding this comment.
On step 5, is there a reason why FE need to sends the delegate action to relayer instead of endpoint handles it on its end?
There was a problem hiding this comment.
We moved to the generic /sign endpoint to make the system more flexible and follow the single responsibility principle. Error handling is a nightmare if we need to pass errors from the relayer to the client. Also, we are designing multichain support now. That will make things even worse without this change.
hcho112
reviewed
Aug 17, 2023
| The expected flow for the client is next: | ||
| 1. Client uses `/user_credentials` endpoint to get the recovery PK. | ||
| 2. Client fetches latest nonce, block hash using obtained recovery PK. | ||
| 3. Client creates a delegate action with desired actions, such as add or delete key. |
There was a problem hiding this comment.
would be nicer if we either link that contains what delegate action format looks like, or have a example code here
There was a problem hiding this comment.
Delegate actions are supported in NAJ and documented here: https://github.com/near/near-api-js/blob/e5570d07b19f618007253ba04b6df8e7af854972/packages/transactions/src/delegate.ts#L37
Terraform Feature Environment Destroy (dev-265)Terraform Initialization ⚙️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.