-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Internalize RwLock into ShiningState #305
Conversation
Terraform Feature Environment (dev-305)Terraform Initialization ⚙️
|
9b78f07
to
ee09a37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Terraform Feature Environment Destroy (dev-305)Terraform Initialization ⚙️
|
This internalizes the RwLock on
ShiningState
. This is only a minor resolution to the issue described in #244Tests before and after with integration tests produced runtimes within margins of noise of +/-10%, since we do not have test that sends multiple requests at once which this PR is aimed towards improving the performance of.
Will add the concurrent tests after because that one actually requires resolving the nonce race issues with near-fetch library and creating stress tests on the network